Support compression= in DataFrame.to_json #17634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
added
Python
Matt711
approved these changes
Dec 19, 2024
| @@ -54,6 +54,22 @@ def _get_cudf_schema_element_from_dtype( | |||
| return lib_type, child_types | |||
|
|
|||
|
|
|||
| def _to_plc_compression( | |||
There was a problem hiding this comment.
Do we use something like this in other places? If so, we could reuse it.
There was a problem hiding this comment.
It looks like we have something similar we use in parquet, but given that each format supports different compression (and maps slightly differently from Python), I can take a look at this in a follow up
| @@ -1453,3 +1453,12 @@ def test_chunked_json_reader(): | |||
| with cudf.option_context("io.json.low_memory", True): | |||
| gdf = cudf.read_json(buf, lines=True) | |||
| assert_eq(df, gdf) | |||
|
|
|||
|
|
|||
| @pytest.mark.parametrize("compression", ["gzip", None]) | |||
There was a problem hiding this comment.
There's a compression_params you could use
Suggested change
| @pytest.mark.parametrize("compression", ["gzip", None]) | |
| @pytest.mark.parametrize("compression", compression_params) |
There was a problem hiding this comment.
Yeah I tried this originally, but it appears gzip is the only supported compression for writing json
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes #17564
Checklist